refactor: compact session list row layout - #155
Merged
Conversation
Merge checkMark and indicator into a single 2-char selector column, reduce tree-mode indent from 4 to 2 spaces, and make the host icon a fixed 2-char column for consistent alignment. Extract applyRowStyle helper to eliminate duplicated style-application blocks. Add tests for narrow-width rendering, tree-mode indent, and selector state transitions. Co-authored-by: Copilot <[email protected]>
- charmbracelet/ultraviolet: 20260615 -> 20260622 - charmbracelet/x/exp/slice: 20260621 -> 20260622 Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tightens the session list row layout by merging the check and cursor columns into a single 2-char selector, reducing tree-mode indent from 4 to 2 spaces, and making the host icon a fixed-width column. Saves 4 chars of prefix space, giving more room for summary text.
Changes
checkMark(2 chars) +indicator(2 chars) into singleselector(2 chars)applyRowStylehelper to eliminate duplicated style-application blocksType of Change
Testing
Quality Gates
mqcrpfsecopsth