Add --max-latency to gate on response time budget#284
Open
jongio wants to merge 1 commit into
Open
Conversation
Add a --max-latency <duration> flag that lets a request finish and then fails with exit code 28 when the total response time is over the budget. This covers CI performance gates that --timeout and --max-time cannot, since those abort a request mid-flight instead of measuring it. The budget is parsed up front, so an invalid value exits with code 2 before any network call is made. The response body is still printed when the budget is exceeded, so only the exit code changes. An empty value disables the check. Co-authored-by: Copilot App <[email protected]>
Contributor
|
🚀 Website Preview Your PR preview is ready! 📎 Preview URL: https://jongio.github.io/azd-rest/pr/284/ This preview will be automatically cleaned up when the PR is closed. |
Contributor
🚀 Test This PRA preview build ( One-Line Install (Recommended)PowerShell (Windows): iex "& { $(irm https://raw.githubusercontent.com/jongio/azd-rest/main/scripts/install-pr.ps1) } -PrNumber 284 -Version 0.5.0-pr284"Bash (macOS/Linux): curl -fsSL https://raw.githubusercontent.com/jongio/azd-rest/main/scripts/install-pr.sh | bash -s 284 0.5.0-pr284UninstallPowerShell (Windows): iex "& { $(irm https://raw.githubusercontent.com/jongio/azd-rest/main/scripts/uninstall-pr.ps1) } -PrNumber 284"Bash (macOS/Linux): curl -fsSL https://raw.githubusercontent.com/jongio/azd-rest/main/scripts/uninstall-pr.sh | bash -s 284Build Info:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #280
What
Adds
--max-latency <duration>, a latency budget gate. After a response finishes, if the total time is over the budget the command exits with code 28 (curl's operation timeout code). The body is still printed, so only the exit code changes.Unlike
--timeoutand--max-time, which abort a request mid-flight, this lets the request complete and then reports whether it was too slow. That is what CI performance gates need, and it pairs well with--fail.Behavior
Tests
parseMaxLatencytable test: empty, valid units, unparseable, zero, negativeDocs
CLI reference gains the
--max-latencyflag row and exit code 28.