Update Arabic Language#24
Conversation
Add Arabic strings for lock and unlock and password features
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughAdds Arabic localized labels and summary text for lock and unlock actions, including locked-state subtitle text with numeric placeholders and password-related guidance strings. ChangesArabic localization update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
app/src/main/res/values-ar/strings.xml (1)
28-28: 🎯 Functional Correctness | 🔵 Trivial | 🏗️ Heavy liftUse a plural resource for
locked_subtitle.Line 28 hard-codes one sentence for all counts, but
VolumeSliderFragment.updateSubtitle()formats it with varyinglockedCount/totalCountvalues. Arabic needs quantity-specific forms, so this will read awkwardly for cases like 1 or 2 locked volumes. Switch this key to<plurals>and update the caller togetQuantityString(...).🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@app/src/main/res/values-ar/strings.xml` at line 28, `locked_subtitle` is currently a single string resource, but `VolumeSliderFragment.updateSubtitle()` uses it with varying counts, so Arabic needs quantity-aware text. Change the `locked_subtitle` resource in the strings XML to a plural resource, then update `updateSubtitle()` to fetch it with `getQuantityString(...)` using `lockedCount` and `totalCount`, so the subtitle renders correctly for different counts.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/main/res/values-ar/strings.xml`:
- Line 32: The Arabic string for the change password summary uses a different
password term than the rest of the screen, which breaks terminology consistency.
Update the string in the values-ar resources for change_password_summary to
match the same wording used by the nearby settings entries in this screen,
keeping the term aligned with the existing Arabic translation style.
---
Nitpick comments:
In `@app/src/main/res/values-ar/strings.xml`:
- Line 28: `locked_subtitle` is currently a single string resource, but
`VolumeSliderFragment.updateSubtitle()` uses it with varying counts, so Arabic
needs quantity-aware text. Change the `locked_subtitle` resource in the strings
XML to a plural resource, then update `updateSubtitle()` to fetch it with
`getQuantityString(...)` using `lockedCount` and `totalCount`, so the subtitle
renders correctly for different counts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 3a7fed33-8b8d-463a-ae87-20ce1a7aece4
📒 Files selected for processing (1)
app/src/main/res/values-ar/strings.xml
Add Arabic strings for lock and unlock and password features
Summary by CodeRabbit