Skip to content

Update Arabic Language#24

Merged
jonathanklee merged 2 commits into
jonathanklee:mainfrom
AhmedAwad7:main
Jun 26, 2026
Merged

Update Arabic Language#24
jonathanklee merged 2 commits into
jonathanklee:mainfrom
AhmedAwad7:main

Conversation

@AhmedAwad7

@AhmedAwad7 AhmedAwad7 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Add Arabic strings for lock and unlock and password features

Summary by CodeRabbit

  • New Features
    • Added Arabic localized UI strings for lock/unlock actions.
    • Added Arabic subtitle text indicating locked status with numeric placeholders.
    • Added Arabic summary text for volume-lowering, password-protected lock changes, and changing passwords.

Add Arabic strings for lock and unlock and password features
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: bb67d296-6158-4145-b794-4f4f3040ab28

📥 Commits

Reviewing files that changed from the base of the PR and between c081566 and 667aec9.

📒 Files selected for processing (1)
  • app/src/main/res/values-ar/strings.xml
✅ Files skipped from review due to trivial changes (1)
  • app/src/main/res/values-ar/strings.xml

📝 Walkthrough

Walkthrough

Adds Arabic localized labels and summary text for lock and unlock actions, including locked-state subtitle text with numeric placeholders and password-related guidance strings.

Changes

Arabic localization update

Layer / File(s) Summary
Arabic lock labels and summaries
app/src/main/res/values-ar/strings.xml
Adds Arabic string resources for lock_all, unlock_all, locked_subtitle, allow_lower_summary, password_protected_summary, and change_password_summary.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

🐰 I hopped through strings both neat and new,
For locks and unlocks, Arabic too.
A subtitle with numbers, crisp and bright,
And password clues that feel just right.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title is clearly related to the PR because it describes an Arabic localization update, even though it is broad.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (1)
app/src/main/res/values-ar/strings.xml (1)

28-28: 🎯 Functional Correctness | 🔵 Trivial | 🏗️ Heavy lift

Use a plural resource for locked_subtitle.

Line 28 hard-codes one sentence for all counts, but VolumeSliderFragment.updateSubtitle() formats it with varying lockedCount/totalCount values. Arabic needs quantity-specific forms, so this will read awkwardly for cases like 1 or 2 locked volumes. Switch this key to <plurals> and update the caller to getQuantityString(...).

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@app/src/main/res/values-ar/strings.xml` at line 28, `locked_subtitle` is
currently a single string resource, but `VolumeSliderFragment.updateSubtitle()`
uses it with varying counts, so Arabic needs quantity-aware text. Change the
`locked_subtitle` resource in the strings XML to a plural resource, then update
`updateSubtitle()` to fetch it with `getQuantityString(...)` using `lockedCount`
and `totalCount`, so the subtitle renders correctly for different counts.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@app/src/main/res/values-ar/strings.xml`:
- Line 32: The Arabic string for the change password summary uses a different
password term than the rest of the screen, which breaks terminology consistency.
Update the string in the values-ar resources for change_password_summary to
match the same wording used by the nearby settings entries in this screen,
keeping the term aligned with the existing Arabic translation style.

---

Nitpick comments:
In `@app/src/main/res/values-ar/strings.xml`:
- Line 28: `locked_subtitle` is currently a single string resource, but
`VolumeSliderFragment.updateSubtitle()` uses it with varying counts, so Arabic
needs quantity-aware text. Change the `locked_subtitle` resource in the strings
XML to a plural resource, then update `updateSubtitle()` to fetch it with
`getQuantityString(...)` using `lockedCount` and `totalCount`, so the subtitle
renders correctly for different counts.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3a7fed33-8b8d-463a-ae87-20ce1a7aece4

📥 Commits

Reviewing files that changed from the base of the PR and between 1b2fdeb and c081566.

📒 Files selected for processing (1)
  • app/src/main/res/values-ar/strings.xml

Comment thread app/src/main/res/values-ar/strings.xml Outdated
@jonathanklee
jonathanklee merged commit b965029 into jonathanklee:main Jun 26, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants