Skip to content

Added Code Mirror to the editor, for extra flair!#1

Open
perpetual-hydrofoil wants to merge 4 commits into
johnregan3:masterfrom
perpetual-hydrofoil:master
Open

Added Code Mirror to the editor, for extra flair!#1
perpetual-hydrofoil wants to merge 4 commits into
johnregan3:masterfrom
perpetual-hydrofoil:master

Conversation

@perpetual-hydrofoil

Copy link
Copy Markdown

image

@perpetual-hydrofoil

Copy link
Copy Markdown
Author

Possible minor Issues with this pull request:

  • using CDNJS instead of including JS directly
  • Injecting js/css loading in form HTML instead of using wp_enqueue_style() or wp_enqueue_script()
  • Although jquery not required so not waiting for jquery document ready, waiting for document ready might still be needed on some browsers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant