Skip to content

fix: hardcode correlation id#2195

Merged
johanbook merged 1 commit into
mainfrom
fix/hardcode-correlation-id
Jul 15, 2026
Merged

fix: hardcode correlation id#2195
johanbook merged 1 commit into
mainfrom
fix/hardcode-correlation-id

Conversation

@johanbook

Copy link
Copy Markdown
Owner

In order to upgrade to Traefik v3 we have to disable correlation id as it is not yet supported there.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request modifies the request context middleware to temporarily hardcode the correlation ID to a static string. The reviewer pointed out that hardcoding this ID will break request tracing and log correlation across different requests, and suggested generating a unique UUID instead when the header is missing.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread services/api/src/core/request-context/request-context.middleware.ts
@johanbook
johanbook merged commit c44e4ea into main Jul 15, 2026
3 checks passed
@johanbook
johanbook deleted the fix/hardcode-correlation-id branch July 15, 2026 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant