Skip to content

Update gorilla to 1.5.2, update go to 1.22.3, and add github action to build and test on each PR - #446

Closed
barakplasma wants to merge 6 commits into
joewalnes:masterfrom
barakplasma:update-gorilla-to-1-5-2
Closed

Update gorilla to 1.5.2, update go to 1.22.3, and add github action to build and test on each PR#446
barakplasma wants to merge 6 commits into
joewalnes:masterfrom
barakplasma:update-gorilla-to-1-5-2

Conversation

@barakplasma

@barakplasma barakplasma commented Jun 10, 2024

Copy link
Copy Markdown

building off of #430

also adds a github action to make sure the makefile builds binaries successfully before allowing a PR to be merged. also tests the binaries by connecting to the example bash script for dump env and making sure it sends an eof at the end
added an example in https://github.com/barakplasma/websocketd/actions/runs/9455903924

easier than using the makefile is to use go-releaser like I'm doing in my fork (generated by the github action workflow at https://github.com/barakplasma/websocketd/blob/master/.github/workflows/release.yml )
I built binaries for all platforms on the latest golang in
https://github.com/barakplasma/websocketd/releases/tag/0.4.2

@barakplasma
barakplasma force-pushed the update-gorilla-to-1-5-2 branch from 177ca55 to f5ba70d Compare June 10, 2024 19:24
@barakplasma barakplasma changed the title Update gorilla to 1.5.2 Update gorilla to 1.5.2 and add github action to run make on PRs Jun 10, 2024
@barakplasma
barakplasma marked this pull request as ready for review June 10, 2024 19:38
@barakplasma barakplasma changed the title Update gorilla to 1.5.2 and add github action to run make on PRs Update gorilla to 1.5.2 and add github action to build and test on each PR Jun 10, 2024
@barakplasma
barakplasma force-pushed the update-gorilla-to-1-5-2 branch from 4181402 to 4e54954 Compare June 10, 2024 21:06
@barakplasma
barakplasma marked this pull request as draft June 10, 2024 21:30
asergeyev and others added 5 commits June 10, 2024 21:37
Convert flag.Usage to flag.CommandLine.Usage for avoid showing the default help message printout
update go version to 1.22.3
fix: nektos/act isn't the same as the runner

fix: another try

fix:

fix:

fix:

fix:

fix:

fix:

fix:

fix:
@barakplasma
barakplasma force-pushed the update-gorilla-to-1-5-2 branch from fc4a874 to 92ff584 Compare June 10, 2024 21:38
@barakplasma
barakplasma marked this pull request as ready for review June 10, 2024 21:40
@barakplasma barakplasma changed the title Update gorilla to 1.5.2 and add github action to build and test on each PR Update gorilla to 1.5.2, update go to 1.22.3, and add github action to build and test on each PR Jun 10, 2024

Copy link
Copy Markdown
Owner

Closing as superseded — everything valuable here has landed via a different path since this was opened:

  • gorilla/websocket is now at v1.5.3 (past the 1.5.2 this targets)
  • Go minimum is now 1.21, with CI on 4 platforms (.github/workflows/test.yml) replacing the need for the proposed build-and-test workflow
  • The main.go redirect-handler bug this PR fixes (unguarded strings.IndexByte(r.Host, ':') when the host has no port) was independently caught and fixed the same way

Thanks for the contribution — the CI and go-releaser ideas were useful references even though the PR itself doesn't apply cleanly anymore.


Generated by Claude Code

@joewalnes joewalnes closed this Jul 9, 2026
@barakplasma
barakplasma deleted the update-gorilla-to-1-5-2 branch July 18, 2026 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants