RenderAction#1
Draft
pedantic-git wants to merge 2 commits into
Draft
Conversation
…r :action or render "path/to/action"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only partway finished - it worked OK on its own but I couldn't get it to play ball with ImplicitRender loaded into the same controller. I thought you'd be interested in my partial work anyway in case you fancy adding a feature like this to Phlexible in the future.
Effectively, it allows (or should allow) calling
render :indexorrender "path/to/index"to load the view in the same way that ImplicitRender does implicitly.This was originally so I could get the Wicked gem to play ball, but in the end I ended up monkeypatching one of its methods to call one of your private methods, which was less code and easier to understand:
Thanks for all your work on this regardless!