Include days to Christmas in the welcome greeting#33
Open
joebew42 wants to merge 5 commits into
Open
Conversation
joebew42
marked this pull request as ready for review
July 8, 2026 11:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When a user joins a chat room they receive a plain welcome message. To make the greeting feel more timely and personable, issue #32 asks for the welcome message to also mention how many days remain until Christmas, with the wording adapting as Christmas gets closer.
This PR
Introduces a dedicated
ExChat.WelcomeMessagemodule that builds the greeting and appends a Christmas clause: a countdown of days to Christmas, a friendly shopping reminder in the final days before, and a celebratory message on Christmas day itself. The join-chat-room use case now delegates message construction to this module. The current date is injected as an optional argument so the logic stays pure and deterministic.Closes #32