Welcome users with a time-of-day greeting#29
Open
joebew42 wants to merge 5 commits into
Open
Conversation
joebew42
marked this pull request as ready for review
July 1, 2026 15:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When a user joins a chat room they receive a static welcome message (
welcome to the <room> chat room, <user>!). We want the greeting to feel more personal and time-aware, so that someone joining in the morning is welcomed differently from someone joining late at night.This PR
Prefixes the join welcome message with a time-of-day greeting addressed to the user, producing messages like
Good morning, a-user! Welcome to the default chat room, a-user!. The mapping from the current time to one of four greetings (morning, afternoon, evening, night) lives in a small pureExChat.Greetingmodule, andJoinChatRoom.on/2takes an injectable clock so the behaviour stays deterministic under test.Closes #28