Conversation
The autoconf check for signal handler behaviour has several problems which lead to extremely confusing error messages and incorrect autoconf behaviour: - RETSIGTYPE is no longer defined because it has long been deprecated; since C89 signal handlers always return void. This causes both a build error and an implicit redefinition to int, leading to more problems. - the test is missing two prototypes for its own functions, which can lead to unexpected failures completely unrelated to signal handling. - very strict compiler settings lead to a warning about an unused function argument in the signal handler. Not critical, but easy to prevent in a portable manner by sinking the signal value into a void expression. With these changes the check compiles cleanly and correctly indicates the expected behaviour to autoconf. Signed-off-by: Holger Hoffstätte <[email protected]>
…`→`. (#92) Turns out that terminals will render in whatever they think the character set is. `→` will appear as itself or three other characters or one other character (the first of the three) or the pop-up text will be missing.
Noticed because I'd set the Ident colour to yellow.
* Fix tags file security vulnerability * Need offset..
* debian.jsf: add missing . to allowed characters in package names. * Fix an off-by-one in rust.jsf.
Caught by libefence.
* Fix selection bugs, make ^Z / ^X consistent * Protect all instances of toggle_marking
* Fix directory name detection in `make` output GNU make doesn't use backticks in its “Entering directory” text (at least, not these days) and, even with that fixed, the text is localised; different locales can and do use different quotation marks around the directory name. So let's check for the pairs found in relevant lines in the GNU make .po files. As this code seems already hard-wired to check for text output by make and there's little point in checking for localised text (without accessing make's compiled translation files), may as well explicitly check for make, allowing for aliases such as "gmake" and "kmk_gmake". * Compiler messages: don't prepend absolute pathnames with the current directory. * Fix missing/broken cases in makefile directory parsing. * Option to ignore files outside ~/ when parsing compile errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hmm, merge changes back to main?