data: jet efficiency maps for b-tagging and dimuon corrections

[kerstinlovisa]

No description provided.

[Copilot]

Pull request overview

This PR updates analysis inputs by refreshing dimuon efficiency scale-factor JSON payloads (including renaming some *_irr2_v3.json datasets to *_irr_v3.json) and adds a Run-2 MET XY (MET-phi modulation) correction helper header under libs/extensions.

Changes:

• Add NanoMETXYCorr_METPhi.hpp with Run-2 era-dependent XY corrections for MET/MET-phi.
• Update multiple data/dimuonEffSFs/*.json scale-factor values and replace/remove several *_pt_irr2_v3.json files with *_pt_irr_v3.json equivalents.
• Introduce new year/era-specific *_pt_irr_v3.json files for PAT/DSA/PatDSA where previously *_irr2_v3.json existed.

Reviewed changes

Copilot reviewed 32 out of 40 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
libs/extensions/include/NanoMETXYCorr_METPhi.hpp	Adds MET XY correction implementation for Run-2 eras (data/MC, UL/non-UL, puppi/non-puppi).
data/dimuonEffSFs/dimuonEffSFs2023preBPix_PatDSA_pt_irr_v3.json	Updates PatDSA dimuon SF values (pre-BPix 2023).
data/dimuonEffSFs/dimuonEffSFs2023preBPix_Pat_pt_irr2_v3.json	Removes older PAT dimuon SF JSON (irr2 variant).
data/dimuonEffSFs/dimuonEffSFs2023preBPix_Pat_pt_irr_v3.json	Adds replacement PAT dimuon SF JSON (irr variant).
data/dimuonEffSFs/dimuonEffSFs2023preBPix_DSA_pt_irr2_v3.json	Removes older DSA dimuon SF JSON (irr2 variant).
data/dimuonEffSFs/dimuonEffSFs2023preBPix_DSA_pt_irr_v3.json	Adds replacement DSA dimuon SF JSON (irr variant).
data/dimuonEffSFs/dimuonEffSFs2023postBPix_PatDSA_pt_irr_v3.json	Updates PatDSA dimuon SF values (post-BPix 2023).
data/dimuonEffSFs/dimuonEffSFs2023postBPix_Pat_pt_irr2_v3.json	Removes older PAT dimuon SF JSON (irr2 variant).
data/dimuonEffSFs/dimuonEffSFs2023postBPix_Pat_pt_irr_v3.json	Updates PAT dimuon SF values (post-BPix 2023).
data/dimuonEffSFs/dimuonEffSFs2023postBPix_DSA_pt_irr2_v3.json	Removes older DSA dimuon SF JSON (irr2 variant).
data/dimuonEffSFs/dimuonEffSFs2023postBPix_DSA_pt_irr_v3.json	Adds replacement DSA dimuon SF JSON (irr variant).
data/dimuonEffSFs/dimuonEffSFs2022preEE_PatDSA_pt_irr_v3.json	Updates PatDSA dimuon SF values (2022 pre-EE).
data/dimuonEffSFs/dimuonEffSFs2022preEE_Pat_pt_irr2_v3.json	Removes older PAT dimuon SF JSON (irr2 variant).
data/dimuonEffSFs/dimuonEffSFs2022preEE_Pat_pt_irr_v3.json	Updates PAT dimuon SF values (2022 pre-EE).
data/dimuonEffSFs/dimuonEffSFs2022preEE_DSA_pt_irr2_v3.json	Removes older DSA dimuon SF JSON (irr2 variant).
data/dimuonEffSFs/dimuonEffSFs2022preEE_DSA_pt_irr_v3.json	Adds replacement DSA dimuon SF JSON (irr variant).
data/dimuonEffSFs/dimuonEffSFs2022postEE_PatDSA_pt_irr_v3.json	Updates PatDSA dimuon SF values (2022 post-EE).
data/dimuonEffSFs/dimuonEffSFs2022postEE_Pat_pt_irr_v3.json	Updates PAT dimuon SF values (2022 post-EE).
data/dimuonEffSFs/dimuonEffSFs2022postEE_DSA_pt_irr_v3.json	Updates DSA dimuon SF values (2022 post-EE).
data/dimuonEffSFs/dimuonEffSFs2018_PatDSA_pt_irr_v3.json	Updates PatDSA dimuon SF values (2018).
data/dimuonEffSFs/dimuonEffSFs2018_Pat_pt_irr_v3.json	Updates PAT dimuon SF values (2018).
data/dimuonEffSFs/dimuonEffSFs2018_DSA_pt_irr_v3.json	Updates DSA dimuon SF values (2018).
data/dimuonEffSFs/dimuonEffSFs2017_PatDSA_pt_irr_v3.json	Updates PatDSA dimuon SF values (2017).
data/dimuonEffSFs/dimuonEffSFs2017_Pat_pt_irr_v3.json	Adds PAT dimuon SF JSON (irr variant) for 2017.
data/dimuonEffSFs/dimuonEffSFs2017_DSA_pt_irr_v3.json	Updates DSA dimuon SF values (2017).
data/dimuonEffSFs/dimuonEffSFs2016preVFP_PatDSA_pt_irr_v3.json	Updates PatDSA dimuon SF values (2016 preVFP).
data/dimuonEffSFs/dimuonEffSFs2016preVFP_Pat_pt_irr_v3.json	Adds PAT dimuon SF JSON (irr variant) for 2016 preVFP.
data/dimuonEffSFs/dimuonEffSFs2016preVFP_DSA_pt_irr_v3.json	Updates DSA dimuon SF values (2016 preVFP).
data/dimuonEffSFs/dimuonEffSFs2016postVFP_PatDSA_pt_irr2_v3.json	Removes older PatDSA dimuon SF JSON (irr2 variant).
data/dimuonEffSFs/dimuonEffSFs2016postVFP_PatDSA_pt_irr_v3.json	Adds replacement PatDSA dimuon SF JSON (irr variant).
data/dimuonEffSFs/dimuonEffSFs2016postVFP_Pat_pt_irr_v3.json	Updates PAT dimuon SF values (2016 postVFP).
data/dimuonEffSFs/dimuonEffSFs2016postVFP_DSA_pt_irr_v3.json	Updates DSA dimuon SF values (2016 postVFP).

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[jniedzie]

Hey @kerstinlovisa, I think these are some sensible comments by copilot - please have a look if you agree.

[kerstinlovisa]

Hey @kerstinlovisa, I think these are some sensible comments by copilot - please have a look if you agree.

Ah I was going to write but forgot: I don't agree just because I didn't make the NanoMETXYCorr_METPhi.hpp script - I just included from CMS recommendations for MET corrections.

I think the config comment is ok, but if it's fine with you, I'd like to just add this small change in another PR - my attempt to make two independent PRs failed, so I suggest we close this one and I work on the next one that needs the NanoMETXYCorr_METPhi.hpp file

[jniedzie]

Hmm, but how is this hpp file going to be used within tea? I think things like making the function inline, adding include guards, etc. are valid concerns. I may have worked fine standalone, but now you're including it in the framework.

[kerstinlovisa]

Hmm, but how is this hpp file going to be used within tea? I think things like making the function inline, adding include guards, etc. are valid concerns. I may have worked fine standalone, but now you're including it in the framework.

Okey, it was easy fix for me to just accept so I did :)