Add Elements.before(Node) and after/prepend/append(Node) #953 - #2567
Merged
Conversation
These were missing next to the string methods. Clone the node for each target so one instance is not moved around the tree. Fixes jhy#953
And tidy up javadoc to current format.
Owner
|
Thanks, merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#953 asked for Elements.before(Node). You said to do the same for after, prepend, and append so they match the string methods.
Each call clones the node. That way inserting into a list does not move one instance between targets, and I am not serializing through HTML.
Tests are in ElementsTest next to the existing string cases.