fix(neptune): initialize _database to fix add_episode AttributeError#3
Closed
jhurliman wants to merge 1 commit into
Closed
fix(neptune): initialize _database to fix add_episode AttributeError#3jhurliman wants to merge 1 commit into
jhurliman wants to merge 1 commit into
Conversation
…sode
NeptuneDriver.__init__ never sets the base GraphDriver._database attribute,
but Graphiti.add_episode reads driver._database (e.g.
`if group_id != self.driver._database:` when mapping a group_id to a database),
so any add_episode call raises:
AttributeError: 'NeptuneDriver' object has no attribute '_database'
Neptune is a single graph with no named databases, so default _database to ''
— consistent with get_default_group_id(GraphProvider.NEPTUNE) returning ''.
The existing with_database()/clone() path (shallow copy reusing the same Neptune
client) then works unchanged.
Owner
Author
|
Closing as redundant — upstream getzep/graphiti already covers this: PR getzep#1539 fixes both Neptune bugs (uninitialized |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1.
NeptuneDriver.__init__never set the baseGraphDriver._databaseattribute, butGraphiti.add_episodereadsself.driver._database— so everyadd_episodeagainst Neptune raisedAttributeError: 'NeptuneDriver' object has no attribute '_database'.Neptune is a single graph with no named databases, so this defaults
_databaseto'', consistent withget_default_group_id(GraphProvider.NEPTUNE)returning''. The inheritedwith_database()/clone()(shallow copy reusing the same Neptune client) works unchanged.Verified against Amazon Neptune Serverless + OpenSearch Serverless (graphiti-core 0.29.2): with this plus #2,
add_episode/searchsucceed end-to-end.