generate-blueprint: apply defaults to selected generators - #34133
Open
patchwork-coder wants to merge 4 commits into
Open
generate-blueprint: apply defaults to selected generators#34133patchwork-coder wants to merge 4 commits into
patchwork-coder wants to merge 4 commits into
Conversation
Fix jhipster#33923 Co-authored-by: OpenAI Codex <[email protected]>
Related to jhipster#33923 Co-authored-by: OpenAI Codex <[email protected]>
Related to jhipster#33923 Co-authored-by: OpenAI Codex <[email protected]>
Keep the focused regression test aligned with the repository file style. Co-authored-by: OpenAI Codex <[email protected]>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #33923
Problem
generate-blueprint --defaults --sub-generators appapplies defaults to the top-level configuration, but still prompts for each selected sub-generator. This blocks unattended blueprint upgrades and exits withExitPromptErrorin non-interactive environments.Change
Apply
defaultSubGeneratorConfig()to every selected built-in and additional sub-generator when--defaultsis enabled. Duplicate selections are collapsed before initializing their storage.A regression test supplies conflicting prompt answers and verifies that the stored per-generator values remain the documented defaults, proving the prompts are skipped.
Verification
npx esmocha generators/generate-blueprint/generator.spec.ts --no-parallel --no-insight— 26 passingnpm run lint— passingnpm run check-types— passingAI assistance disclosure
OpenAI Codex assisted with reproducing the issue, implementing the focused change, and preparing the regression test. The resulting diff was reviewed and tested locally. Both commits include a
Co-authored-by: OpenAI Codex <[email protected]>trailer.Please make sure the below checklist is followed for Pull Requests.
Co-authored-by:trailers