Fix surrogate decoding and invalid hex handling#466
Open
MichaelChirico wants to merge 1 commit into
Open
Conversation
Avoid crashes/asserts when decoding invalid surrogate pairs or truncated unicode escapes in yajl_string_decode.
35285b5 to
6c2ca00
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was an error produced by a fuzzer we set up for yajl, fixed by Gemini, and ported to this bundled version by Gemini.
YAJL's string decoder could crash (
SIGABRT) or read out-of-bounds when encountering invalid unicode escape sequences or surrogate pairs:hexToDigitusedassertto validate hex characters, causing crashes on invalid input (e.g.,\u005g).\uescape.Solution:
Improve robustness of unicode decoding in
yajl_encode.c:hexToDigitto return a success status (int) instead of asserting, allowing callers to handle parsing errors gracefully.end + 6 < len) before attempting to parse a low surrogate.0xDC00to0xDFFF) before combining.?and break parsing of the escape sequence on any invalid input or bounds violation.