just a test PR#245
Open
glehmann wants to merge 3 commits into
Open
Conversation
The checkPRs polling loop in AppShell called getPREnrichment and fetchInvolvedPRs without error handling. When the GitHub API was unreachable, the promise rejection was unhandled (fire-and-forget), producing an 'Uncaught (in promise) HttpError: NetworkError'. Wrapped the polling body in try/catch so transient network failures are silently ignored and polling continues on the next interval.
glehmann
force-pushed
the
gln/pr-update-indicator-pink-unzm
branch
2 times, most recently
from
b9c621c to
97d3aaa
Compare
Two bugs fixed in app-shell.tsx: 1. handleTabSelect called markTabUpdated instead of clearTabUpdated when clicking a tab (despite the comment saying 'Clear updated flag'). This caused the ⟳ to flash briefly when selecting a tab. 2. The updated indicator was a solid orange dot (bg-orange-500). Changed to orange ⟳ with transparent background.
glehmann
force-pushed
the
gln/pr-update-indicator-pink-unzm
branch
from
97d3aaa to
f9a1167
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.