Simplify Mac instance creation#54
Open
jchambers wants to merge 1 commit into
Open
Conversation
jchambers
force-pushed
the
simplify_mac_instance_creation
branch
from
48be08f to
f8541ee
Compare
jchambers
force-pushed
the
simplify_mac_instance_creation
branch
from
f8541ee to
15aec63
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've gone back and forth about this over time, but the more time I spend with security stuff, the more I think "simple is better." This change simplifies
Macinstance creation at the expense of a significant drop in throughput.Here's throughput before this change:
benchmarkGenerateOneTimePasswordbenchmarkGenerateOneTimePasswordString…and after:
benchmarkGenerateOneTimePasswordbenchmarkGenerateOneTimePasswordStringI'll leave this open for feedback for a while, but unless somebody objects, I'll plan to merge before the next release (whenever that happens—there's no pressing need for a new release right now).