Skip to content

Fix signing requirement against signing required#356

Open
laxa wants to merge 1 commit into
jborean93:masterfrom
laxa:fix_signing_required
Open

Fix signing requirement against signing required#356
laxa wants to merge 1 commit into
jborean93:masterfrom
laxa:fix_signing_required

Conversation

@laxa

@laxa laxa commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

When using smbprotocol, with require_signing=False on the Connection class, against a computer requiring signing (a Domain Controller for example), the client fails to update its client_security_mode as stated in the specification section 3.2.4.2.2.2.

image

EDIT: force pushed to update test case that failed with the initial PR

@codecov

codecov Bot commented Jun 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.78%. Comparing base (9b8e7d4) to head (01ff473).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #356   +/-   ##
=======================================
  Coverage   98.78%   98.78%           
=======================================
  Files          24       24           
  Lines        5276     5277    +1     
=======================================
+ Hits         5212     5213    +1     
  Misses         64       64           
Flag Coverage Δ
macOS 68.20% <0.00%> (-0.02%) ⬇️
py3.10 98.78% <100.00%> (+<0.01%) ⬆️
py3.11 98.78% <100.00%> (+<0.01%) ⬆️
py3.12 98.78% <100.00%> (+<0.01%) ⬆️
py3.13 98.78% <100.00%> (+<0.01%) ⬆️
py3.14 98.78% <100.00%> (+<0.01%) ⬆️
ubuntu 96.62% <100.00%> (+<0.01%) ⬆️
windows 98.71% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@laxa laxa force-pushed the fix_signing_required branch from 1ecb7d2 to 01ff473 Compare June 9, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant