Skip to content

Fix tests, modernize Tox config, and use Python to generate test MaxMind database#193

Open
blag wants to merge 8 commits intomasterfrom
fix-tests
Open

Fix tests, modernize Tox config, and use Python to generate test MaxMind database#193
blag wants to merge 8 commits intomasterfrom
fix-tests

Conversation

@blag
Copy link
Copy Markdown
Contributor

@blag blag commented Mar 15, 2026

Description

Tests were not working on my machine, so I fixed them.
I also updated the Tox config to only test versions of Python and Django that were still supported by upstream. Except for Django 4.2, since support for that ends in about only six weeks.
Lastly, instead of using a Perl script wrapped in a Docker image to generate the MMDB files for tests, I converted that to a Python script.

Motivation and Context

Tests now run (again), and our test process is simplified and dependencies minified.

How Has This Been Tested?

All tests run and pass.

Types of changes

  • Administrative changes

Checklist:

  • My code follows the code style of this project.
  • All new and existing tests passed.

@blag blag requested a review from WhyNotHugo March 15, 2026 10:35
Comment thread tests/generate_mmdb.py Outdated
Comment thread tests/test_admin.py
Comment thread pyproject.toml Outdated
Comment thread pyproject.toml Outdated
Comment thread tox.ini Outdated
@blag
Copy link
Copy Markdown
Contributor Author

blag commented Mar 15, 2026

Hold off on merging this just yet, looking into an issue with mmdb-writer.

@WhyNotHugo
Copy link
Copy Markdown
Member

Ack

@blag
Copy link
Copy Markdown
Contributor Author

blag commented Apr 19, 2026

Okay, I figured out how to test out using country MMDB files and enabled that. This PR should be ready to merge after review. Thank you for your patience.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants