Ship: verified-memory gate on by default; preset ladder (Quality gate on, Integrity strict) - #173
Conversation
… on, Integrity strict) Jay signed off on the prefer_verified default flip (E-018 tri-judge: served- hallucination 0.040 to 0.000 under all three judge families at no measured accuracy or recall cost) and on the E-012 ship shape. The gate was already on at the bare default (the runtime falls back to prefer_verified when nothing is persisted); this makes the presets honour 'on across tiers' and records the decision. Preset ladder, three clear rungs: - Minimal: gate off (the lean opt-out), no rerank. - Quality: gate on alongside reranking, the recommended accuracy tier. - Integrity: steps up to the strict gate, which drops unverified claims for maximum purity and accepts a small measured recall trade-off. profiles.resolve_config now accepts an explicit pinned value in a profile override (e.g. prefer_verified='strict') in addition to a bool, so the installer Integrity profile can write strict. Reranking stays on in the recommended retrieve recipe; answer self-verification stays an opt-in consumer-side recommendation enabled in the Quality and Integrity profiles, since taOSmd serves memory and does not generate answers. Updated controls.py + profiles.py, the README and INTEGRATION preset tables, CHANGELOG, and the profile/controls tests. Full suite 970 pass.
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughEnables Changesprefer_verified global default and preset ladder
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Note Your trial team has used its Gitar budget, so automatic reviews are paused. Upgrade now to unlock full capacity. Comment "Gitar review" to trigger a review manually. Code Review ✅ ApprovedEnables the verified-memory gate by default across Quality and Integrity presets, establishing a clear ladder for memory safety and accuracy tiers. All configuration overrides, documentation, and tests successfully updated to support the new preset hierarchy. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Important Your trial ends in 4 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more. Was this helpful? React with 👍 / 👎 | Gitar |
Finalizes the two ship decisions you signed off on.
The flip was already live at the bare default.
config.get_controlsfalls back toprefer_verified(on) when nothing is persisted, andget_runtime_overridesexcludes unset controls so the recommended recipe's reranker stays on. So this PR makes the presets honour 'on across tiers' and records the decision; it does not change the out-of-the-box default (which was already on).Decision 1 (prefer_verified flip on). Backed by E-018: served-hallucination 0.040 to 0.000 under all three judge families (llama / qwen-instruct / gemma) at n=250, at no measured accuracy or recall cost. The preset ladder is now three clear rungs:
offprefer_verifiedstrictThis resolves the prior inconsistency where Quality (the common accuracy pick) silently turned the gate off.
profiles.resolve_confignow accepts an explicit pinned value in a profile override (so Integrity can writestrict), in addition to the existing bool switches.Decision 2 (E-012 ship: rerank default + self-verify opt-in). No code change was needed: reranking is already on in the recommended retrieve recipe and in the Quality/Integrity presets, and answer self-verification stays an opt-in consumer-side recommendation enabled in the Quality and Integrity install profiles (taOSmd serves memory; answer generation is the consumer's path). Documented as such.
Updated
controls.py,profiles.py, the README and INTEGRATION preset tables, the CHANGELOG, and the profile/controls/http tests. Full suite 970 pass. The research-report status flip (F-011/E-018 pending-Jay to signed-off) will follow on merge.Summary by CodeRabbit
Release Notes
Documentation
Tests