fix(github): resolve #2009/#1932 semantic conflict on App private key source

tests/test_routes_github.py

@@ -341,18 +341,23 @@ def _build_app_with_app_config(
     app = FastAPI()
     app.include_router(github_router)
 
-    # SecretsStore (PAT)
+    # SecretsStore: PAT under ``github_token``, App key under
+    # ``github-app-private-key`` (moved out of config by #2009).
     mock_secrets = MagicMock()
-    if token:
-        mock_secrets.get = AsyncMock(return_value={"value": token})
-    else:
-        mock_secrets.get = AsyncMock(return_value=None)
+
+    async def _secrets_get(name):
+        if name == "github_token":
+            return {"value": token} if token else None
+        if name == "github-app-private-key":
+            return {"value": "fake-private-key"}
+        return None
+
+    mock_secrets.get = AsyncMock(side_effect=_secrets_get)
     app.state.secrets = mock_secrets
 
-    # App config
+    # App config (private key no longer lives here after #2009)
     mock_config = MagicMock()
     mock_config.github_app_id = "123456"
-    mock_config.github_app_private_key = "fake-private-key"
     app.state.config = mock_config
 
     # App installations store

tinyagentos/routes/github.py

@@ -120,7 +120,7 @@ async def _get_app_installation_token(
         from tinyagentos.github_app import get_installation_token
 
         token = await get_installation_token(
-            cfg.github_app_id, cfg.github_app_private_key, installation_id,
+            cfg.github_app_id, private_key, installation_id,
             http_client,
         )
         if token: