Skip to content

refactor(desktop): split NotesApp into notes-only component with shared module #2037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hognek wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

refactor(desktop): split NotesApp into notes-only component with shared module #2037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 2 additions & 27 deletions desktop/src/apps/NotesApp.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { render, screen, act, waitFor, within, fireEvent } from "@testing-library/react";
import { render, screen, act, waitFor, fireEvent } from "@testing-library/react";
import { describe, it, expect, vi, beforeEach } from "vitest";
import { NotesApp, TodoApp } from "./NotesApp";
import { NotesApp } from "./NotesApp";

function mockFetch(
resolver: (url: string, init?: RequestInit) => { ok: boolean; status?: number; body: unknown },
Expand Down Expand Up @@ -177,28 +177,3 @@ describe("NotesApp", () => {
}));
});
});

describe("TodoApp", () => {
beforeEach(() => {
vi.restoreAllMocks();
});

it("renders only lists, filtering out notes that share the same API", async () => {
vi.stubGlobal(
"fetch",
mockFetch(() => ({ ok: true, body: [noteDoc, listDoc] })),
);
render(<TodoApp windowId="w2" />);
await flush();

await waitFor(() => expect(screen.getByText("Sprint backlog")).toBeTruthy());
expect(screen.queryByText("Project kickoff")).toBeNull();
});

it("shows the todo empty state when there are no lists", async () => {
vi.stubGlobal("fetch", mockFetch(() => ({ ok: true, body: [] })));
render(<TodoApp windowId="w2" />);
await flush();
await waitFor(() => expect(screen.getByText(/no lists yet/i)).toBeTruthy());
});
});
Loading
Loading