This repository was archived by the owner on Feb 5, 2019. It is now read-only.
Fix (un)marshal bug #1135#1155
Open
NiasSt90 wants to merge 1 commit into
Open
Conversation
|
Hi Guys, Can some one please review the change and know if any further changes are required ? |
|
@bravehorsie @zhengjl Would you please review it? Thank you very much! :) |
|
@bravehorsie, @zhengjl, guys, can you please review these changes ? |
Member
|
Looks type information is lost due to |
|
@bravehorsie, thanks for reviewing this. We have a user business use case that needs a fix on this. If the changes seems to be fine, can we include them in jaxb-v2 on the latest branch ? |
|
Guys, is there any update on this ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
i'm not sure if the hasSubClasses() is enough in all cases.
perhaps there should be a general way to disable this optimization on demand/fallback (system-property).
it works in my case (see the reproducer project mentioned in the bug report).