Adding new flag for the User Auth action to use with OSDJoin TS vars#4
Open
OswaldsArbitraryDomiciles wants to merge 3 commits into
Open
Adding new flag for the User Auth action to use with OSDJoin TS vars#4OswaldsArbitraryDomiciles wants to merge 3 commits into
OswaldsArbitraryDomiciles wants to merge 3 commits into
Conversation
…OSDJoin username and password.
…OSDJoin username and password.
…OSDJoin username and password.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds an additional optional flag to the UserAuth action - "UseforOSDJoin". When enabled, this will take the authenticated domain, username, and password and assign the appropriate values to the two standard Task Sequence variables "OSDJoinAccount" and "OSDJoinPassword" These can then be used by OSD as the credentials to automatically join the device to the AD domain.
Sample usage:
<Action Type="UserAuth" Name="User Authentication" Title="Please authenticate to continue." Domain="example.com" Group="OSDUsers" GetGroups="True" MaxRetryCount="5" DisableCancel="True" DoNotFallback="True" UseForOSDJoin="True"></Action>NOTE: This does have the side effect of storing the password as plaintext via the TS var, but that's always been an issue with the OSDJoin variables. Regardless, I felt that this was worth clarifying.
Disclaimer: I don't usually program, I usually just sysadministrate and I have not written any C++ code in like 20 years. That said, the contributed code does compile and does what it is supposed to, so I clearly remembered something from my CS classes. My apologies if I did something wrong, especially with GitHub stuff as I have very little experience with it.