Skip to content

Zeromq/cleanup - #214

Open
techntools wants to merge 4 commits into
jaredwray:mainfrom
techntools:zeromq/cleanup
Open

Zeromq/cleanup#214
techntools wants to merge 4 commits into
jaredwray:mainfrom
techntools:zeromq/cleanup

Conversation

@techntools

Copy link
Copy Markdown
Contributor

Please check if the PR fulfills these requirements

These changes removes redundant awaiting and remove topic filter from ZMQ socket as well when topic is being unsubscribed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the ZmqMessageProvider to unsubscribe from a topic on the ZeroMQ subscriber socket when deleting a subscription, and removes the await keyword when closing the subscriber and publisher sockets. The review feedback points out a potential resource leak where the ZeroMQ socket remains subscribed to a topic if the last handler for that topic is removed individually by its ID, and provides a code suggestion to resolve this issue.

Comment thread packages/zeromq/src/index.ts
@codecov

codecov Bot commented Aug 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.93%. Comparing base (aca21a4) to head (229d6b2).

Additional details and impacted files
@@             Coverage Diff             @@
##              main     #214      +/-   ##
===========================================
- Coverage   100.00%   99.93%   -0.07%     
===========================================
  Files           12       12              
  Lines         1659     1663       +4     
  Branches       288      290       +2     
===========================================
+ Hits          1659     1662       +3     
- Misses           0        1       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant