Zeromq/cleanup - #214
Open
techntools wants to merge 4 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the ZmqMessageProvider to unsubscribe from a topic on the ZeroMQ subscriber socket when deleting a subscription, and removes the await keyword when closing the subscriber and publisher sockets. The review feedback points out a potential resource leak where the ZeroMQ socket remains subscribed to a topic if the last handler for that topic is removed individually by its ID, and provides a code suggestion to resolve this issue.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
===========================================
- Coverage 100.00% 99.93% -0.07%
===========================================
Files 12 12
Lines 1659 1663 +4
Branches 288 290 +2
===========================================
+ Hits 1659 1662 +3
- Misses 0 1 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
techntools
force-pushed
the
zeromq/cleanup
branch
from
August 2, 2026 10:36
a9ec3ae to
229d6b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
These changes removes redundant awaiting and remove topic filter from ZMQ socket as well when topic is being unsubscribed