Skip to content

fix deprecated function util.isArray to Array.isArray #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janudewangga wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix deprecated function util.isArray to Array.isArray #81

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/flash.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@ var isArray = require('util').isArray;
* @return {Function}
* @api public
*/
module.exports = function flash(options) {
module.exports = function flash (options) {
options = options || {};
var safe = (options.unsafe === undefined) ? true : !options.unsafe;
return function(req, res, next) {

return function (req, res, next) {
if (req.flash && safe) { return next(); }
req.flash = _flash;
next();
Expand Down Expand Up @@ -56,16 +56,16 @@ module.exports = function flash(options) {
* @return {Array|Object|Number}
* @api public
*/
function _flash(type, msg) {
function _flash (type, msg) {
if (this.session === undefined) throw Error('req.flash() requires sessions');
var msgs = this.session.flash = this.session.flash || {};
if (type && msg) {
// util.format is available in Node.js 0.6+
if (arguments.length > 2 && format) {
var args = Array.prototype.slice.call(arguments, 1);
msg = format.apply(undefined, args);
} else if (isArray(msg)) {
msg.forEach(function(val){
} else if (Array.isArray(msg)) {
msg.forEach(function (val) {
(msgs[type] = msgs[type] || []).push(val);
});
return msgs[type].length;
Expand Down