`bigint` is slightly different from the clj version

[djblue]

Jank:

% jank repl
user=> (bigint "42N")
42N
user=> (bigint "42")
42N

Clojure:

% clj
Clojure 1.12.2
user=> (bigint "42N")
Execution error (NumberFormatException) at java.lang.NumberFormatException/forInputString (NumberFormatException.java:67).
For input string: "42N"
user=> (bigint "42")
42N

[jeaye]

Yeah, we have explicit support for this:

  void big_integer::init(jtl::immutable_string const &s)
  {
    if(s.empty())
    {
      throw std::runtime_error(util::format("Failed to construct BigInteger from empty string"));
    }

    try
    {
      if(s.ends_with('N'))
      {
        data.assign(std::string(s.substr(0, s.size() - 1)));
      }
      else
      {
        data.assign(std::string(s));
      }
    }
    catch(std::exception const &e)
    {
      throw std::runtime_error(
        util::format("Failed to construct BigInteger from string '{}': {}", s, e.what()));
    }
  }

Seemed like a nice win, which allows big ints to round trip.

[djblue]

Ohh, for serialization in portal, I round trip via: (-> 42N str bigint). Additionally supporting (-> 42N pr-str bigint) doesn't hurt 👍 Feel free to close this if you want to keep this behavior. I just thought it would be worth noting.