Use patched version of hoxy#407
Closed
jamezrin wants to merge 4 commits into
Closed
Conversation
Member
|
@jamezrin thanks for the PR! I'm looking forward to having that hoxy fix be merged. Unfortunately, though that does make I checked out your branch locally, but I was still able to reproduce the bug:
If you invoke the AppImage from the terminal, you can see the logs. On my machine in my most-recent test, it crashed with: I don't recall James failing like this in the past, so I'm not sure if this is caused by:
Let me know if you can reproduce the problem, and thanks again for digging into this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patched version propagates exceptions created by the sockets to the main event emitter, check greim/hoxy#110
The force push is because I accidentally reverted 97993f4 which would remove the changelog entry for the previous release, so I deleted the handler myself
It works locally, but I think the way I have done this makes no sense (the submodules) so sorry for this, I wanted the commits I created to be visible, but I could've just set my repository on the package.json, but for some reason that wasn't working well when
npm installing.I don't think the PR to hoxy will get merged, it is not maintainted. So maybe the james-proxy can fork it with that fix in it?