Prove portable WebView ACL grants - #241
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting
Skipping any of the above? Explain why here:
None.
Description
Use Microsoft's exact unquoted numeric-SID syntax for the fixed WebView2 runtime ACL grants. Add a Windows CI probe that compiles and runs both quoted and unquoted forms through the same pinned NSIS 3.11 toolchain as Tauri, compares them with a direct
icaclscontrol, and verifies explicit and inherited rules by numeric SID.The probe showed that quoted, unquoted, and direct invocations produce identical ACLs. This confirms that the failed release check was a false negative from PowerShell's convenience
.Accessenumeration, not an NSIS serialization failure. The signed release verification now usesGetAccessRuleswithSecurityIdentifieroutput and logs rawicaclsoutput, access-only SDDL, and numeric access rules before asserting permissions.The NSIS archive is verified against Tauri CLI 2.10.0's pinned SHA-1 before use.
Related issues
Relates to #141.
Testing
bun run lintbunx tsc --noEmitbun run test(285 passing)bunx prettier --check .github/workflows/ci.yml .github/workflows/release.yml scripts/portable-webview-workflow.test.tsbun run buildgit diff --checkcargo fmt --checkcould not run locally because this runtime does not have Cargo installed. No Rust files changed, and required GitHub CI runs the repository formatting gate.Screenshots / videos (optional)
Not applicable; this changes installer permissions and workflow verification only.