Fix fixed-runtime portable packaging - #239
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
./from the fixed WebView2 runtime path so Tauri packages the runtime directly under its configured directory.INSTALLWEBVIEW2MODEvalue for fixed-runtime-only NSIS behavior.msedgewebview2.exemust be directly inside the configured runtime directory.Root cause
Release run 30699825159 successfully built, signed, and installed the fixed-runtime artifact, then found the runtime nested as
Runtime/Runtime/.... AudioBud's base resources are a map. Tauri 2.10 adds the configured fixed-runtime path to that map and normalizes the walked source; the previous./prefix preventedstrip_prefixfrom matching, so the full source directory was appended below the destination. Tauri 2.10 also rendersFixedRuntimeas an empty NSIS mode, so the priorfixedRuntimeguards never compiled.This is a follow-up to #39.
Validation
bun test(285 passing)bun run lintbunx tsc --noEmitbun run buildgit diff --check