Skip to content

here's a minor compile fix & a fix to allow resources to be copied as part of the compile (rather than just watch) and deal with non-existing target directories#12

Open
jstrachan wants to merge 3 commits into
jakewins:masterfrom
fusesource:2abbca4237c4a6acda2c4b8354d11292f29eb5d9

Conversation

@jstrachan

Copy link
Copy Markdown

No description provided.

@jakewins

jakewins commented Dec 2, 2011

Copy link
Copy Markdown
Owner

I know test coverage in this project is so-so, so I feel bad asking since I'm not really walking the walk.. but could you add a small test case, to make sure these improvements don't get broken further down the road?

It should be possible to create another integration test project, or extend one that already exists, that would have failed before this change, see here: https://github.com/jakewins/brew/tree/master/src/functionaltest/testprojects

Looked through the code as well, looks really good, thank you so much for contributing. Will pull in as soon as a test has been added to the project.

@jstrachan

Copy link
Copy Markdown
Author

Agreed :)

Yeah; I'm trying to hack in CoffeeJade support at the moment...
https://github.com/fusesource/coffeejade

Will add an integration test in there using new directories as part of
that new integration test.

On 2 December 2011 12:00, Jacob Hansson
[email protected]
wrote:

I know test coverage in this project is so-so, so I feel bad asking since I'm not really walking the walk.. but could you add a small test case, to make sure these improvements don't get broken further down the road?

It should be possible to create another integration test project, or extend one that already exists, that would have failed before this change, see here: https://github.com/jakewins/brew/tree/master/src/functionaltest/testprojects

Looked through the code as well, looks really good, thank you so much for contributing. Will pull in as soon as a test has been added to the project.


Reply to this email directly or view it on GitHub:
#12 (comment)

James

FuseSource
Email: [email protected]
Web: http://fusesource.com
Twitter: jstrachan
Blog: http://macstrac.blogspot.com/

Open Source Integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants