Skip to content

Update DataSourceDefinition.java#141

Open
coiouhkc wants to merge 2 commits into
jakartaee:masterfrom
coiouhkc:patch-1
Open

Update DataSourceDefinition.java#141
coiouhkc wants to merge 2 commits into
jakartaee:masterfrom
coiouhkc:patch-1

Conversation

@coiouhkc

@coiouhkc coiouhkc commented Sep 3, 2024

Copy link
Copy Markdown

fix typo (extra space) in TRANSACTION_READ_ UNCOMMITTED

@coiouhkc

coiouhkc commented Sep 3, 2024

Copy link
Copy Markdown
Author

@lukasj , @m0mus - where do I need to sign? ;)
I've signed the Eclipse Contributor Agreement (ECA) and have an active Eclipse account with matching Email and Github handles.

@lukasj

lukasj commented Sep 5, 2024

Copy link
Copy Markdown
Contributor

@lukasj

lukasj commented Sep 5, 2024

Copy link
Copy Markdown
Contributor

ah, the failing check is some beta which I think we can safely ignore

@lukasj lukasj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just update 2023 in copyright header to 2024, please

Update copyright header (date)
@pzygielo

pzygielo commented Sep 6, 2024

Copy link
Copy Markdown

Just checking, @coiouhkc - are you with Oracle?

@coiouhkc

coiouhkc commented Sep 6, 2024

Copy link
Copy Markdown
Author

Just checking, @coiouhkc - are you with Oracle?

No, I'm with OpenValue now (https://de.linkedin.com/in/alexei-bratuhin-21647811, if it helps), but contributing in my personal time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants