Merge standardModuleMapping into single knownIncludes#313
Open
davispuh wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR consolidates the previously duplicated include-to-module mappings (standardModuleMapping and knownIncludes) into a single shared knownIncludes mapping so both HeaderIndex and IncludeHandler can rely on one source of truth.
Changes:
- Moved/centralized
knownIncludesintoHeaderIndex.dand re-used it fromHeaderIndexconstructor. - Removed
standardModuleMappingfromHeaderIndexand removed the oldknownIncludesinitialization fromIncludeHandler. - Simplified
IncludeHandler.isKnownIncludeto a direct lookup (but this introduces a behavioral regression; see comments).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dstep/translator/IncludeHandler.d | Removes local knownIncludes and changes how includes are recognized as “known”. |
| dstep/translator/HeaderIndex.d | Introduces package-level knownIncludes and uses it as the single module-mapping source. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
168
to
172
| string isKnownInclude (string include) | ||
| { | ||
| import std.path : stripExtension, baseName; | ||
|
|
||
| include = stripExtension(baseName(include)); | ||
|
|
||
| if (auto ptr = include in knownIncludes) | ||
| return *ptr; | ||
| else |
Comment on lines
+235
to
+237
| "math.h" : "core.stdc.math", | ||
| "signal.h" : "core.stdc.signal", | ||
| "stdarg.h" : "core.stdc.stdarg", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently there is
standardModuleMappingandknownIncludeswhich are basically duplicates and does similar thing so merge them into single mapping.