Reuse remote repository sources#2315
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2315 +/- ##
===========================================
- Coverage 93.30% 37.03% -56.27%
===========================================
Files 128 128
Lines 28392 29017 +625
===========================================
- Hits 26491 10747 -15744
- Misses 1901 18270 +16369 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
📦 Cargo Bloat ComparisonBinary size change: +0.72% (27.7 MiB → 27.9 MiB) Expand for cargo-bloat outputHead Branch ResultsBase Branch Results |
⚡️ Hyperfine BenchmarksSummary: 0 regressions, 0 improvements above the 10% threshold. Environment
CLI CommandsBenchmarking basic commands in the main repo:
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base --version |
2.2 ± 0.1 | 2.0 | 2.8 | 1.01 ± 0.08 |
prek-head --version |
2.1 ± 0.1 | 2.0 | 3.1 | 1.00 |
prek list
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base list |
9.3 ± 0.3 | 8.9 | 11.5 | 1.00 |
prek-head list |
9.7 ± 0.2 | 9.1 | 10.2 | 1.05 ± 0.04 |
prek validate-config .pre-commit-config.yaml
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base validate-config .pre-commit-config.yaml |
3.1 ± 0.0 | 3.0 | 3.2 | 1.00 |
prek-head validate-config .pre-commit-config.yaml |
3.2 ± 0.1 | 3.0 | 3.5 | 1.01 ± 0.03 |
prek sample-config
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base sample-config |
2.4 ± 0.0 | 2.3 | 2.6 | 1.00 |
prek-head sample-config |
2.5 ± 0.0 | 2.4 | 2.5 | 1.01 ± 0.02 |
Cold vs Warm Runs
Comparing first run (cold) vs subsequent runs (warm cache):
prek run --all-files (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
78.2 ± 2.0 | 73.8 | 80.9 | 1.01 ± 0.03 |
prek-head run --all-files |
77.4 ± 1.1 | 75.7 | 79.4 | 1.00 |
prek run --all-files (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
76.5 ± 2.1 | 73.4 | 80.3 | 1.00 |
prek-head run --all-files |
77.0 ± 2.2 | 72.0 | 79.7 | 1.01 ± 0.04 |
Full Hook Suite
Running the builtin hook suite on the benchmark workspace:
prek run --all-files (full builtin hook suite)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --all-files |
78.6 ± 2.6 | 74.5 | 85.4 | 1.00 |
prek-head run --all-files |
79.4 ± 3.3 | 73.5 | 93.5 | 1.01 ± 0.05 |
Individual Hook Performance
Benchmarking each hook individually on the test repo:
prek run trailing-whitespace --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run trailing-whitespace --all-files |
20.3 ± 0.6 | 19.5 | 21.9 | 1.00 |
prek-head run trailing-whitespace --all-files |
20.6 ± 0.5 | 19.7 | 21.7 | 1.01 ± 0.04 |
prek run end-of-file-fixer --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run end-of-file-fixer --all-files |
26.7 ± 2.0 | 24.3 | 30.2 | 1.02 ± 0.11 |
prek-head run end-of-file-fixer --all-files |
26.2 ± 2.2 | 23.6 | 30.5 | 1.00 |
prek run check-json --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-json --all-files |
7.6 ± 0.3 | 7.1 | 8.2 | 1.00 |
prek-head run check-json --all-files |
7.6 ± 0.2 | 7.1 | 8.0 | 1.00 ± 0.05 |
prek run check-yaml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-yaml --all-files |
7.4 ± 0.1 | 7.2 | 7.6 | 1.00 |
prek-head run check-yaml --all-files |
7.5 ± 0.1 | 7.2 | 7.7 | 1.01 ± 0.02 |
prek run check-toml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-toml --all-files |
7.6 ± 0.3 | 7.2 | 8.4 | 1.00 ± 0.05 |
prek-head run check-toml --all-files |
7.6 ± 0.3 | 7.1 | 8.0 | 1.00 |
prek run check-xml --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-xml --all-files |
7.4 ± 0.4 | 7.1 | 8.6 | 1.00 |
prek-head run check-xml --all-files |
7.5 ± 0.3 | 7.1 | 8.4 | 1.01 ± 0.07 |
prek run detect-private-key --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run detect-private-key --all-files |
13.5 ± 1.0 | 11.8 | 16.3 | 1.00 |
prek-head run detect-private-key --all-files |
14.2 ± 1.2 | 12.1 | 16.7 | 1.05 ± 0.12 |
prek run fix-byte-order-marker --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run fix-byte-order-marker --all-files |
18.1 ± 0.8 | 17.1 | 20.6 | 1.00 |
prek-head run fix-byte-order-marker --all-files |
18.4 ± 0.7 | 17.5 | 19.9 | 1.02 ± 0.06 |
Installation Performance
Benchmarking hook installation (fast path hooks skip Python setup):
prek install-hooks (cold - no cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
4.4 ± 0.1 | 4.4 | 4.5 | 1.00 |
prek-head install-hooks |
4.5 ± 0.0 | 4.4 | 4.5 | 1.01 ± 0.02 |
prek install-hooks (warm - with cache)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base install-hooks |
4.4 ± 0.0 | 4.4 | 4.4 | 1.00 |
prek-head install-hooks |
4.4 ± 0.0 | 4.4 | 4.5 | 1.01 ± 0.01 |
File Filtering/Scoping Performance
Testing different file selection modes:
prek run (staged files only)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run |
37.0 ± 0.9 | 35.7 | 39.8 | 1.00 |
prek-head run |
37.9 ± 2.4 | 36.1 | 45.1 | 1.03 ± 0.07 |
prek run --files '*.json' (specific file type)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --files '*.json' |
7.9 ± 0.1 | 7.7 | 8.1 | 1.01 ± 0.02 |
prek-head run --files '*.json' |
7.8 ± 0.1 | 7.7 | 8.0 | 1.00 |
Workspace Discovery & Initialization
Benchmarking hook discovery and initialization overhead:
prek run --dry-run --all-files (measures init overhead)
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run --dry-run --all-files |
6.7 ± 0.1 | 6.5 | 6.8 | 1.01 ± 0.02 |
prek-head run --dry-run --all-files |
6.6 ± 0.1 | 6.5 | 6.9 | 1.00 |
Meta Hooks Performance
Benchmarking meta hooks separately:
prek run check-hooks-apply --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-hooks-apply --all-files |
12.4 ± 1.3 | 11.2 | 15.1 | 1.08 ± 0.12 |
prek-head run check-hooks-apply --all-files |
11.4 ± 0.2 | 11.2 | 11.9 | 1.00 |
prek run check-useless-excludes --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run check-useless-excludes --all-files |
11.5 ± 0.3 | 11.2 | 12.4 | 1.06 ± 0.05 |
prek-head run check-useless-excludes --all-files |
10.8 ± 0.4 | 10.3 | 11.4 | 1.00 |
prek run identity --all-files
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
prek-base run identity --all-files |
9.7 ± 0.1 | 9.6 | 10.0 | 1.00 |
prek-head run identity --all-files |
9.9 ± 0.5 | 9.7 | 11.4 | 1.02 ± 0.05 |
Summary
Closes #1743
Closes #1309