Continue conversation after Assist tool calls#4
Merged
Conversation
Owner
Author
|
Review note: I reviewed the tool-call loop fix and reran local verification. The change is narrowly scoped: it keeps text-only turns stopping normally, but uses the streamed tool-call event as the signal to continue into the follow-up model pass after HA returns tool results. CI is green and local ruff/tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Home Assistant may consume/store script tool results immediately, leaving
chat_log.unresponded_tool_resultsempty by the time Codex Assist checks it. In that case Codex Assist stopped after the tool call and the UI stayed at...until the next user message.Tracking whether the model requested a tool call during the stream is the better signal that a follow-up model pass is needed.
Verification
uv run ruff check .uv run pytest -q