Add support for filtering by status#560
Open
redcatbear wants to merge 1 commit into
Open
Conversation
|
kaklakariada
requested changes
Jul 12, 2026
| */ | ||
| public boolean isStatusCriteriaSet() | ||
| { | ||
| return this.wantedStatuses != null && !this.wantedStatuses.isEmpty(); |
Contributor
There was a problem hiding this comment.
Add a non null check to the constructor and remove the null Check here
Comment on lines
+42
to
+43
| assertThat(filterSettings.getWantedStatuses(), containsInAnyOrder(expectedStatuses)); | ||
| assertFilterSet(filterSettings, true); |
Comment on lines
+7
to
+8
| We added a new feature to filter specification items by status at import time via `-w` or `--wanted-statuses` CLI parameters. | ||
| This is helpful when your project uses specification documents for planning future requirements (marked by the status "draft" or "porposed"). |
Contributor
There was a problem hiding this comment.
A typical use case is to exclude only draft items. If I understand correctly, this would require specifying all other status in this option?
Another remark: We often don't use the status field for items. Only when we add items we mark them as draft. Would it be possible to allow including items without status?
| () -> assertThat(getOutputFileContent(), containsString("2 total")), | ||
| () -> assertThat(getOutputFileContent(), containsString("req~draft~1")), | ||
| () -> assertThat(getOutputFileContent(), containsString("req~proposed~1")), | ||
| () -> assertThat(getOutputFileContent(), not(containsString("req~approved~1"))) |
Contributor
There was a problem hiding this comment.
Suggested change
| () -> assertThat(getOutputFileContent(), not(containsString("req~approved~1"))) | |
| () -> assertThat(getOutputFileContent(), not(containsString("approved"))) |
be more strict
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds functionality to filter items by their status.
Introduces new command line switch
-wand--wanted-statusesCloses #519.