Correctly throw error when un-selectable image card is marked as selected#1343
Open
brentswisher wants to merge 3 commits into
Open
Correctly throw error when un-selectable image card is marked as selected#1343brentswisher wants to merge 3 commits into
brentswisher wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: d7f0f1e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
satya-achanta-venkata
approved these changes
Jul 21, 2026
lizlove
requested changes
Jul 21, 2026
brentswisher
force-pushed
the
fix/image-card-selectable-check
branch
from
July 21, 2026 17:47
31178db to
c6515ca
Compare
Co-authored-by: Elizabeth Lovero <[email protected]>
brentswisher
force-pushed
the
fix/image-card-selectable-check
branch
from
July 21, 2026 20:49
c6515ca to
d7f0f1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change: (check at least one)
Is this a breaking change? (check one)
Is the: (complete all)
What does this change address?
Fixes #1331
How does this change work?
The image card has several variants which can be selected: (https://pharos.jstor.org/storybook/?path=/story/web-components_components-image-card--selectable)
This can be set programmatically by passing a
selectedattribute to the web component. The component has some logic that ifselectedwas set on an image card but it was not one of the variants which allowed for selection, it should throw an error.There was a bug in the logic, while the HTML attribute is
selected, the Lit property that maps to it is_isSelected, and the code was checking the wrong thing. In addition, the logic was inverse so if it was working it would have thrown errors for selectable variants when they were selected 🙃 .This fixes the logic so the error will be thrown as originally intended, and re-enables the test that exercises this logic.