Expressions unification#177
Open
DaanVanVugt wants to merge 3 commits into
Open
Conversation
DaanVanVugt
requested review from
MireilleSchneider,
SBlokhuizen and
maarten-ic
as code owners
SBlokhuizen
reviewed
Jun 25, 2026
| @@ -0,0 +1,135 @@ | |||
| import ast | |||
Comment on lines
86
to
89
| # Derived waveforms are parsed as YAML block strings | ||
| elif "'" in editor_text or '"' in editor_text: | ||
| indented_text = textwrap.indent(editor_text, " ") | ||
| waveform_yaml = f"{name}: |\n{indented_text}" |
Collaborator
There was a problem hiding this comment.
Don't think this will work anymore with the new expressions.
Comment on lines
+9
to
+12
| # Configuration schema version. Bumped to 2 when bare-string values became literal | ||
| # string constants instead of derived-waveform expressions. | ||
| CURRENT_SCHEMA_VERSION = 2 | ||
|
|
Collaborator
There was a problem hiding this comment.
If we want to have YAML schema versions, should we use semantic versioning instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After #176