Suppress stdout from env loading script to avoid python exec pollution#54
Merged
Merged
Conversation
Without this suppression environment loading scripts that give verbose information (e.g. intel setvars.sh) will have these lines executed by the Python `exec()` function. Best case, it is total nonsense and throws an error, worst case it executes some catastrophic code. Note that the loader still executes perceived differences in the env, so users should be cautious about loading scripts and be aware of code injection.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this suppression environment loading scripts that give verbose information (e.g. intel setvars.sh) will have these lines executed by the Python
exec()function. Best case, it is total nonsense and throws an error, worst case it executes some catastrophic code.Note that the loader still executes perceived differences in the env, so users should be cautious about loading scripts and be aware of code injection.