Add a helper function for changing the state of __exec_raw__#47
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Control of whether the output of
Action.execute_subprocess()is dictated by the internalActionattribute__exec_raw__.If users need to execute some subprocess within their custom Action with wrapped logging output, they need to ensure this value is set correctly. Likewise, to ensure consistent logging, users would need to reinstate the previous value after the subprocess finishes.
Rather than require temp variable and read/write of a private variable the control can now be facilitated by a push/pop set of helper functions.
pop_exec_raw()should only be called after a correspondingpush_exec_raw()call. Multiple nested calls are not supported at this time (e.g. multiple push before equivalent pop) as it is meant to only wrap aroundexecute_subprocess()calls.