fix(config): keep a Hugging Face model ID out of path normalisation - #617
Open
fg618455-droid wants to merge 1 commit into
Open
fix(config): keep a Hugging Face model ID out of path normalisation#617fg618455-droid wants to merge 1 commit into
fg618455-droid wants to merge 1 commit into
Conversation
whisper_model accepts a size name, a repo ID, or a directory, but every value went through path expansion. On Windows that rewrote the separator in "owner/model" to a backslash, and the loader rejected the result as an invalid model size, so no model outside the built-in size names could be used on that platform. Expansion now applies to what is recognisably a path: a tilde, an absolute path, or something that exists on disk. Everything else is an identifier and is passed through as written.
fg618455-droid
commented
Aug 17, 2026
fg618455-droid
left a comment
Author
There was a problem hiding this comment.
Self-review (APPROVE not permitted on own PR via API): clean, well-scoped fix for a real Windows-only bug (path normalisation mangling a Hugging Face repo ID's separator). Minimal diff, good test coverage (repo-ID pass-through + still-normalises-a-real-directory), verified against the real model end-to-end per the PR description. No blocking issues; CI green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
whisper_modelaccepts a size name (`medium`), a Hugging Face repo ID (`owner/model`), or a local directory, but every value went through path expansion.deepdml/faster-whisper-large-v3-turbo-ct2to a backslash, and the loader then rejected the result as an invalid model size, so no model outside the built-in size names could be used on that platform.Test plan
pytest tests/test_config_path_expansion.py(7 tests, new coverage for the size/repo-ID/path distinction)deepdml/faster-whisper-large-v3-turbo-ct2loads correctly withHF_HUB_OFFLINE=1on Windows after this fix