feat: add compile-time enum dimension labels via MetricDimension trait#99
Open
brayniac wants to merge 9 commits into
Open
feat: add compile-time enum dimension labels via MetricDimension trait#99brayniac wants to merge 9 commits into
brayniac wants to merge 9 commits into
Conversation
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
…tion Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
…th MetricDimension derive Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MetricDimensiontrait mapping enum variants to dense array indices and label strings, with a cartesian-product(A, B)tuple impl for multi-dimensional metricsDimensionedCounter<D>,DimensionedGauge<D>, andDimensionedHistogram<D>wrappers that useD: MetricDimensionto provide named accessor methods over the underlyingCounterGroup/GaugeGroup/HistogramGroup#[derive(MetricDimension)]proc macro for enums so callers avoid hand-writing the trait implTest Plan
cargo nextest run --all-targets --all-features --locked— 84 tests passcargo clippy --all-targets --all-features— cleancargo fmt --all -- --check— cleanmetriken/tests/dimensioned_metrics.rscover single-dimension and cartesian-product usage, inc..value(),.set(),.increment(),.add(), and metadata propagation🤖 Generated with Claude Code