Skip to content

Operator API | Add default_values and fixed_values to filters #748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phylor merged 1 commit into from
Jul 15, 2026
+12 −0
Merged

Operator API | Add default_values and fixed_values to filters #748

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions lib/ioki/model/operator/reporting/report_aggregation_filter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,14 @@ class ReportAggregationFilter < Base
attribute :localized_values,
on: :read,
type: :array

attribute :default_values,
on: :read,
type: :array

attribute :fixed_values,
on: :read,
type: :array
end
end
end
Expand Down
4 changes: 4 additions & 0 deletions spec/ioki/model/operator/reporting/report_aggregation_filter_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,12 +18,16 @@
it { is_expected.to define_attribute(:localized_name).as(:string) }
it { is_expected.to define_attribute(:values).as(:array) }
it { is_expected.to define_attribute(:localized_values).as(:array) }
it { is_expected.to define_attribute(:default_values).as(:array) }
it { is_expected.to define_attribute(:fixed_values).as(:array) }

it 'casts filter metadata' do
expect(filter.name).to eq('operator_id')
expect(filter.localized_name).to eq('Operator')
expect(filter.values).to eq(%w[op-1 op-2])
expect(filter.localized_values).to eq(%w[Op-1 Op-2])
expect(filter.default_values).to be_nil
expect(filter.fixed_values).to be_nil
end

it 'accepts unrestricted filter values' do
Expand Down