Fix focus trap stealing focus on render#737
Open
Luminous9 wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Why
FocusLock registers its focus-trap effect with no dependency array, so it re-runs on every render, and the focus correction is scheduled through an uncancelled
setTimeout(..., 50). On each run, iffocusInside(trap)is false, it callsmoveFocusInsideto pull focus back to the trap's first tabbable element.The probelm is that
focusInsidechecksdocument.activeElementat the moment the delayed callback fire, not static DOM containment. When the lock re-renders repeatedly (e.g. user keystrokes inside a nested overlay's input) the trap re-checks focus during transient windwos wheredocument.activeElementisn't yet the intended element. It reads that as "focus escaped" and takes focus away, so typing a single character bounces focus out of the input field.The fix gates the effect on activation transitions and stops state delayed
moveFocusInsidefrom firing during a transient blur.