Skip to content

FifoChecker unsafe use of previousValue on error signal fix#292

Open
kimmeljo wants to merge 1 commit into
intel:mainfrom
kimmeljo:fifocheck_error_bug
Open

FifoChecker unsafe use of previousValue on error signal fix#292
kimmeljo wants to merge 1 commit into
intel:mainfrom
kimmeljo:fifocheck_error_bug

Conversation

@kimmeljo

Copy link
Copy Markdown
Contributor

Description & Motivation

In some cases code can be reached in FifoChecker where we examine the error signal's value (by calling toBool()) without first checking if the value is valid. When this happens, the Simulator crashes.

In this case, it seems safe and still correct to just further qualify the code to check for the value being valid.

Related Issue(s)

N/A

Testing

Confirmed to work in user environment but hard to reproduce in unit tests. Given the scope of the fix, no further testing is really needed.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

Fully backwards compatible.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

No.

@kimmeljo kimmeljo requested review from desmonddak and mkorbel1 June 17, 2026 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant