fix(wizard): properly parse markdown lists for CVE Notes#198
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the CVE add wizard’s Notes formatting so that Markdown-style unordered list items (* / -) are preserved as list items (with proper indentation and wrapping) instead of being folded into surrounding paragraph text.
Changes:
- Add
_asListItem()helper to detect*/-list items and extract marker + content. - Refactor
_formatAsNoteText()to parse paragraphs into text vs list-item segments and render list items with a hanging indent. - Add comprehensive unit tests covering list detection, mixed markers, lists at the start of a note, lists between paragraphs, and wrapping behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
cvelib/wizard.py |
Implements list-item detection and updates note formatting to preserve list structure. |
tests/test_wizard.py |
Adds test coverage for list parsing/formatting scenarios and wrapping expectations. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| for cont_line in continuation_wrapped: | ||
| result_lines.append(f"{continuation_prefix}{cont_line}") | ||
| if not wrapped: | ||
| # Marker with no content, eg a bare "*" |
jdstrand
force-pushed
the
jdstrand/fix-md-lists
branch
from
e0d1d51 to
0dd5726
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.