Status column for condition display ILLDEV-342#9
Merged
Conversation
skomorokh
requested review from
adamdickmeiss,
ihardy,
jakub-id and
kurtnordstrom
as code owners
There was a problem hiding this comment.
Pull request overview
Adds support for displaying (and counting) condition “receipt” outcomes by introducing a Status column for loan conditions and aligning chat notification “read/unread” logic to treat ACCEPTED/REJECTED as read.
Changes:
- Added a new translation string for the “Rejected” condition status.
- Added a
statuscolumn to the loan-conditions MultiColumnList, derived from the condition notificationreceipt. - Centralized “read” detection via
isNotificationReadand updated unseen counting + chat message normalization accordingly.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| translations/ui-rs/en.json | Adds the “Rejected” label for condition status display. |
| src/components/Flow/FlowViewComponents/LoanConditions.js | Introduces a Status column and receipt→status message-id mapping for condition notifications. |
| src/components/chat/useNotifications.js | Adds isNotificationRead and updates unseen-count logic to treat ACCEPTED/REJECTED as read. |
| src/components/chat/ChatPane.js | Uses isNotificationRead when normalizing notifications into chat message props. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.