Scheduled actions ILLDEV-412#11
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR implements a new “Scheduled actions” settings area for ui-rs, including list/detail views, create/edit forms, a small scheduling model (cron ↔︎ {days,times}), and the necessary i18n strings/dependencies.
Changes:
- Replaces the previous placeholder Scheduled Actions settings page with a full CRUD UI backed by
broker/batch_actions. - Adds a weekly-schedule conversion/formatting layer (
scheduleExpression,model) and UI inputs for days + UTC times. - Introduces per-action parameter blocks via a small action registry, plus Jest coverage for the new model/UI pieces.
Reviewed changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| translations/ui-rs/en.json | Adds i18n strings for Scheduled Actions settings UI. |
| src/settings/ScheduledActionsSettings.js | Removes the previous placeholder pane component. |
| src/settings/index.js | Wires Scheduled Actions into Settings with localized section/page labels. |
| src/settings/scheduledActions/index.js | Adds barrel export for the Scheduled Actions settings module. |
| src/settings/scheduledActions/ScheduledActions.js | Implements list page + nested routes for new/view/edit. |
| src/settings/scheduledActions/ScheduledActions.test.js | Adds list rendering test with human-readable schedule assertion. |
| src/settings/scheduledActions/ViewScheduledAction.js | Implements detail view with edit/delete action menu and confirmation modal. |
| src/settings/scheduledActions/CreateScheduledAction.js | Implements create flow via react-query mutation + okapiKy POST. |
| src/settings/scheduledActions/EditScheduledAction.js | Implements edit flow via react-query mutation + okapiKy PUT. |
| src/settings/scheduledActions/ScheduledActionForm.js | Adds shared form for create/edit: action selector, query, schedule, params. |
| src/settings/scheduledActions/ScheduledActionForm.test.js | Adds tests for params inclusion/clearing and day selection behavior. |
| src/settings/scheduledActions/model.js | Adds form-values ↔︎ API record mapping helpers. |
| src/settings/scheduledActions/model.test.js | Adds unit tests for model mapping helpers. |
| src/settings/scheduledActions/actions/actionRegistry.js | Defines mapping of actionName → params component. |
| src/settings/scheduledActions/actions/EmailPullslipsParams.js | Adds params UI for email action (attachPdf). |
| src/settings/scheduledActions/actions/AgeRequestsParams.js | Adds params UI for age-requests action (tier durations). |
| src/settings/scheduledActions/schedule/scheduleExpression.js | Adds cron parsing/formatting + human-readable schedule summary. |
| src/settings/scheduledActions/schedule/scheduleExpression.test.js | Adds unit tests for cron conversion and display formatting. |
| src/settings/scheduledActions/schedule/TimesField.js | Adds repeatable UTC Timepicker field for selecting run times. |
| src/settings/scheduledActions/schedule/DaysOfWeek/DaysOfWeek.js | Adds custom day-of-week toggle control integrated with final-form. |
| src/settings/scheduledActions/schedule/DaysOfWeek/DaysOfWeek.css | Adds styling for day-of-week toggle control. |
| package.json | Adds final-form array dependencies used by the schedule times UI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
skomorokh
requested review from
adamdickmeiss,
ihardy,
jakub-id and
kurtnordstrom
as code owners
jakub-id
reviewed
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.