systemd: switch to Type=exec#90
Closed
adamdickmeiss wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the packaged systemd unit files for zebrasrv (both RPM and Debian variants) to run the server in the foreground under systemd using Type=exec, removing the previous Type=forking/PIDFile approach.
Changes:
- Switch
zebrasrvsystemd units fromType=forkingtoType=execand drop daemonizing / PIDFile usage. - Simplify
ExecStartto run without-D(daemonize) and without writing/run/zebrasrv.pid. - Add
ExecReloadand adjustRestartpolicy.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| rpm/zebrasrv.service | Updates the RPM-installed systemd unit to Type=exec and adjusts start/restart/reload behavior. |
| debian/idzebra-2.0-utils.zebrasrv.service | Mirrors the same systemd unit changes for the Debian packaging. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+9
to
+11
| Type=exec | ||
| EnvironmentFile=/etc/sysconfig/zebrasrv | ||
| ExecStart=/bin/sh -c "exec ${DAEMON} ${OPTIONS} -p /run/zebrasrv.pid -D" | ||
| PIDFile=/run/zebrasrv.pid | ||
| Restart=on-abnormal | ||
| ExecStart=/bin/sh -c "exec ${DAEMON} ${OPTIONS}" |
| PIDFile=/run/zebrasrv.pid | ||
| Restart=on-abnormal | ||
| ExecStart=/bin/sh -c "exec ${DAEMON} ${OPTIONS}" | ||
| ExecReload=kill -HUP $MAINPID |
| Restart=on-abnormal | ||
| ExecStart=/bin/sh -c "exec ${DAEMON} ${OPTIONS}" | ||
| ExecReload=kill -HUP $MAINPID | ||
| Restart=on-abort |
Comment on lines
+9
to
+11
| Type=exec | ||
| EnvironmentFile=/etc/default/zebrasrv | ||
| ExecStart=/bin/sh -c "exec ${DAEMON} ${OPTIONS} -p /run/zebrasrv.pid -D" | ||
| PIDFile=/run/zebrasrv.pid | ||
| Restart=on-abnormal | ||
| ExecStart=/bin/sh -c "exec ${DAEMON} ${OPTIONS}" |
| PIDFile=/run/zebrasrv.pid | ||
| Restart=on-abnormal | ||
| ExecStart=/bin/sh -c "exec ${DAEMON} ${OPTIONS}" | ||
| ExecReload=kill -HUP $MAINPID |
| Restart=on-abnormal | ||
| ExecStart=/bin/sh -c "exec ${DAEMON} ${OPTIONS}" | ||
| ExecReload=kill -HUP $MAINPID | ||
| Restart=on-abort |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.