Pin esbuild to >=0.28.1 (GHSA-g7r4-m6w7-qqqr)#68
Merged
Conversation
esbuild <0.28.1 has a Windows-only path traversal in the dev server's `servedir` handler — `path.Clean()` only normalizes forward slashes, so backslash sequences let an attacker escape the configured root and read arbitrary files. Dependabot advisory #6 flagged js/pnpm-lock.yaml; [email protected] is pulled transitively via vite/vitest in the workspace. Added an esbuild override to js/pnpm-workspace.yaml, regenerated the lockfile (esbuild 0.27.7 -> 0.28.1 across every @esbuild/* platform package), and refreshed nix/packages.nix pnpmDeps.hash to the new sandbox value (per the pnpm-deps-nix-hash workflow). Verified `nix build .#pnpmDeps` succeeds against the new hash. Generated with [Indent](https://indent.com) Co-Authored-By: Indent <[email protected]>
Coverage
|
Pre-existing formatting drift on main: prettier --check fails on EMBEDDING.md, js/core/src/BlitConnection.ts, node-wasm.ts, and __tests__/BlitTerminalSurface.test.ts. Main's CI for the same commits is also red on the lint job for the same reason, so this PR inherits the failure. Running prettier --write is the minimal fix. Generated with [Indent](https://indent.com) Co-Authored-By: Indent <[email protected]>
|
🔗 Preview: https://blit-eiawzpkdw-indent.vercel.app |
pcarrier
approved these changes
Jun 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
esbuild: ">=0.28.1"tojs/pnpm-workspace.yamloverrides.js/pnpm-lock.yaml; esbuild and every@esbuild/*platform package move from0.27.7to0.28.1.nix/packages.nixpnpmDeps.hashto the new sandbox value (sha256-trgB0v4s+NeYvQnfQErcu3T9akU23oPfXYiGcinbTug=) per the pnpm-deps Nix hash workflow.Motivation
Dependabot advisory #6 (GHSA-g7r4-m6w7-qqqr):
esbuild>=0.27.3, <0.28.1has a Windows-only path traversal in its dev server'sservedirhandler.path.Clean()only normalizes forward slashes, so a backslash sequence like..\..\..\Windows\system.iniescapes the configured root. We never run esbuild's dev server directly, butvite/vitestpull the vulnerable tarball into the lockfile, which is enough to trip Dependabot.Testing
pnpm install --lockfile-only(pnpm 10.33.0) regenerated cleanly; every@esbuild/*resolution now points at0.28.1.nix build .#pnpmDepssucceeds against the new hash locally (caught the old hash mismatch on the first run, pasted thegot:value back per the existing workflow).Unrelated to this change:
js/pnpm-workspace.yamlalready hadvite: ^7, but the lockfile resolves[email protected]via vitest — that drift is pre-existing and not touched here.Tag
@indentto continue the conversation here.